Defer MixpanelFlutterPlugin registration and initialization to prevent ANRs #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR defers the registration and initialization of the MixpanelFlutterPlugin to prevent potential ANRs during plugin registration. It implements lazy initialization for the MethodChannel, stores the FlutterPluginBinding for later use, and ensures proper cleanup in onDetachedFromEngine.
- Lazy initialization of the MethodChannel in handleInitialize
- Storing the FlutterPluginBinding for deferred channel registration
- Cleaning up channel and binding references in onDetachedFromEngine
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| android/src/main/java/com/mixpanel/mixpanel_flutter/MixpanelFlutterPlugin.java | Defers channel registration and adds lazy initialization to avoid ANRs |
| README.md | Updates Markdown formatting for consistency in the “I want to know more!” section |
android/src/main/java/com/mixpanel/mixpanel_flutter/MixpanelFlutterPlugin.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer MethodChannel setup from onAttachedToEngine into handleInitialize(...), so the channel is only created when Dart calls initialize(). This lazy registration prevents blocking the main thread during engine startup (including headless/Firebase isolates) and eliminates the ANR.
Key Changes
• Move new MethodChannel(...) + setMethodCallHandler(this) into handleInitialize() guarded by channel == null && flutterPluginBinding != null
• Leave onAttachedToEngine() free of any codec or messenger work
• Ensure flutterPluginBinding is stored on attach for later use in initialization